Hydro Reservoir Levels Check #2513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nikolaredstork
commented
Dec 4, 2024
| && (colMin[day] < 0 || colAvg[day] < 0 || colMin[day] > colMax[day] | ||
| || colAvg[day] > 100 || colMax[day] > 100)) | ||
| && (0 > colMin[day] || colMin[day] > colAvg[day] || colAvg[day] > colMax[day] | ||
| || colMax[day] > 100)) |
There was a problem hiding this comment.
@flomnes Also, variables colMin[day], colMax[day], colAvg[day] contains values between 0-1, so comparing values with 100 is a bug, we need to compare it with 1.
Would you be able to confirm that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, minimum reservoir levels can be greater than average reservoir levels and average reservoir levels can be greater than maximum reservoir levels.
This PR introduces new checking logic: 0 <= minLevel <= avgLevel <= maxLevel <= 100
With new checking logic minimum levels cannot be greater than average levels and average levels cannot be greater than maximum levels.
Note: Function where Antares is checking reservoir levels is called
checkReservoirLevels, but also in this function Antares is checking inflow patterns (data that is used for TS generator) and credit modulation data. Maybe this function should be renamed or broken down into three separate functions.