Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for Thermal costs, fix wrong values in GUI #2526

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 6, 2024

Advantages

  • Better separation of responsabilities, remove a lot of if..else
  • Make sure that if costgeneration = setManually (legacy behavior), no new code is executed

Cons

  • The caller needs to call function ThermalCluster::getCostProvider first

GUI

Previously, the formula used for modulation columns was "netCost = modulation * modulation * originalCost" for market bid & marginal costs. We fix this formula to "netCost = modulation * originalCost"

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Dec 6, 2024
@flomnes flomnes requested review from sylvlecl and payetvin December 6, 2024 09:45
@flomnes flomnes merged commit 001e6d5 into develop Dec 10, 2024
10 checks passed
@flomnes flomnes deleted the fix/thermal-costs branch December 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants