Data for modeler (epic 4.1) #2577

guilpier-code · 2025-01-14T07:27:34Z

Associated to epic 4.1.
Associated to ticket ANT-2031

…terface

… instead of old concrete LinearProblemData

src/solver/modeler/api/include/antares/solver/modeler/api/linearProblemData.h

a-zakir · 2025-01-14T09:44:10Z

It would be a good idea to write some tests that demonstrate the use cases of the new interface.

… LinearProblemData We plan to have one unique instance this latter class

…ion from its abstract parent

…: TimeSeriesSet

…dataSeries) + cleaning

src/solver/modeler/api/CMakeLists.txt

src/solver/modeler/api/include/antares/solver/modeler/api/ILinearProblemData.h

src/tests/src/solver/modeler/api/CMakeLists.txt

src/tests/src/solver/optim-model-filler/CMakeLists.txt

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/dataSeriesRepo.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h

…ta-for-new-modeler--4.1

src/solver/modeler/main.cpp

flomnes

Use custom exceptions
No need to pass std::unique_ptr ?

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/dataSeries.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/dataSeriesRepo.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/scenarioGroupRepo.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h

src/solver/modeler/dataSeries/scenarioGroupRepo.cpp

guilpier-code · 2025-01-22T12:33:26Z

No need to pass std::unique_ptr ?

As said here, passing std::unique_ptr is a way to force a piece of data to be held in one place only.
Once passed to another container with an add() method, the passed data gets empty outside the container, and the life time of the data becomes the life time of the container.
For example the data series repository is the only place to hold a IDataSeries (which can be a set of TS) because these IDataSeries were passed as std::unique_ptr .
Instead of storing a std::unique_ptr to a IDataSeries in the data series repo, we could point it with a reference or a classic pointer, but what's the point of that ?
Are we supposed to reuse external TS independently once they are stored in the LinearProblemData ?

…roducing custom exceptions

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/dataSeriesRepo.h

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h

src/solver/modeler/dataSeries/linearProblemData.cpp

flomnes · 2025-01-23T13:06:04Z

src/solver/modeler/dataSeries/timeSeriesSetExceptions.cpp

Use custom exceptions in this file

… custom exceptions

…t on scenario group repository

…e check in production code

…ta-for-new-modeler--4.1

sonarqubecloud · 2025-01-29T11:03:25Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

guilpier-code added 2 commits January 13, 2025 18:16

Data for new modeler : make class linearProblemData derive from an in…

8459ed0

…terface

Data for new modeler (4.1) : passing new interface ILinearProblemData…

df7656c

… instead of old concrete LinearProblemData

guilpier-code requested review from flomnes, a-zakir, pet-mit and payetvin January 14, 2025 07:27

guilpier-code self-assigned this Jan 14, 2025

pull-request-size bot added the size/L label Jan 14, 2025

guilpier-code commented Jan 14, 2025

View reviewed changes

src/solver/modeler/api/include/antares/solver/modeler/api/linearProblemData.h Outdated Show resolved Hide resolved

src/solver/modeler/api/include/antares/solver/modeler/api/linearProblemData.h Outdated Show resolved Hide resolved

[skip ci] Data for new modeler (4.1) : clang format

d6db716

guilpier-code marked this pull request as draft January 14, 2025 08:40

guilpier-code added 16 commits January 16, 2025 15:29

[skip ci] Data for new modeler (4.1) : remove commented code

2c2b769

Data for new modeler (4.1) : adding a data series repository to class…

7701b5b

… LinearProblemData We plan to have one unique instance this latter class

Data for new modeler (4.1) : separate linear problem data implementat…

448ca34

…ion from its abstract parent

Data for new modeler (4.1) : packaging a data-series-lib library

252a670

Data for new modeler (4.1) : clang format

60cf26b

Data for new modeler (4.1) : coding scenario group repository

a12cb4b

Data for new modeler (4.1) : testing scenario group repository

99c2a7f

Data for new modeler (4.1) : avoid use of std::format(..)

1816792

Data for new modeler (4.1) : fix for Linux

2ad9df2

Data for new modeler (4.1) : adding an implementation of IDataSeries …

965173f

…: TimeSeriesSet

Data for new modeler (4.1) : coding the data series repository

fe02503

Data for new modeler (4.1) : compilation fix

a73c08d

Data for new modeler (4.1) : clang format

ce46a25

Data for new modeler (4.1) : unit testing for time series set

12f6d0c

Data for new modeler (4.1) : clang format

9d4d566

Data for new modeler (4.1) : mainly testind data series repository

35cd165

pull-request-size bot added size/XL and removed size/L labels Jan 20, 2025

guilpier-code added 3 commits January 20, 2025 17:04

Data for new modeler (4.1) : start for testing linear problem data

62a5437

Data for new modeler (4.1) : moving linear problem data (from api to …

3eea870

…dataSeries) + cleaning

Data for new modeler (4.1) : tiny corrections

f7829c0

guilpier-code commented Jan 21, 2025

View reviewed changes

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/dataSeriesRepo.h Show resolved Hide resolved

guilpier-code commented Jan 21, 2025

View reviewed changes

src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h Show resolved Hide resolved

guilpier-code added 3 commits January 21, 2025 15:33

Data for new modeler (4.1) : adding unit tests on linear problem data

654b97e

Data for new modeler (4.1) : adding unit tests on time series set

6118f76

Merge remote-tracking branch 'remotes/origin/develop' into feature/da…

ea803e8

…ta-for-new-modeler--4.1

guilpier-code marked this pull request as ready for review January 21, 2025 15:40

guilpier-code commented Jan 21, 2025

View reviewed changes

src/solver/modeler/main.cpp Show resolved Hide resolved

Formatting

4549a6a

flomnes reviewed Jan 22, 2025

View reviewed changes

guilpier-code added 5 commits January 23, 2025 10:56

[skip ci] Data for new modeler (4.1) : correction due to review

47bb961

[skip ci] Data for new modeler (4.1) : correction due to review

7f3ecb8

[skip ci] Data for new modeler (4.1) : correction due to review

981d02f

[skip ci] Data for new modeler (4.1) : correction due to review

f0029c3

[skip ci] Data for new modeler (4.1) : correction due to review : int…

6bbaeea

…roducing custom exceptions

flomnes reviewed Jan 23, 2025

View reviewed changes

guilpier-code added 3 commits January 23, 2025 14:53

[skip ci] Data for new modeler (4.1) : correction due to review > add…

7e47a49

… custom exceptions

[skip ci] Data for new modeler (4.1) : adding an exception + unit tes…

ce6d3d4

…t on scenario group repository

[skip ci] Data for new modeler (4.1) : add custom exceptions + add on…

5bca306

…e check in production code

pull-request-size bot added size/XXL and removed size/XL labels Jan 23, 2025

guilpier-code added 2 commits January 23, 2025 17:03

Data for new modeler (4.1) : more fix due to review

7550fc1

Merge remote-tracking branch 'remotes/origin/develop' into feature/da…

a9974e9

…ta-for-new-modeler--4.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data for modeler (epic 4.1) #2577

Data for modeler (epic 4.1) #2577

guilpier-code commented Jan 14, 2025 •

edited

Loading

a-zakir commented Jan 14, 2025

flomnes left a comment

guilpier-code commented Jan 22, 2025 •

edited

Loading

flomnes Jan 23, 2025

guilpier-code Jan 23, 2025

sonarqubecloud bot commented Jan 29, 2025

Data for modeler (epic 4.1) #2577

Are you sure you want to change the base?

Data for modeler (epic 4.1) #2577

Conversation

guilpier-code commented Jan 14, 2025 • edited Loading

a-zakir commented Jan 14, 2025

flomnes left a comment

Choose a reason for hiding this comment

guilpier-code commented Jan 22, 2025 • edited Loading

flomnes Jan 23, 2025

Choose a reason for hiding this comment

guilpier-code Jan 23, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 29, 2025

Quality Gate passed

guilpier-code commented Jan 14, 2025 •

edited

Loading

guilpier-code commented Jan 22, 2025 •

edited

Loading