Modeler 4.7: Import connections and ports #2662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/io/inputs/model-converter/include/antares/io/inputs/model-converter/modelConverter.h
Outdated
Show resolved
Hide resolved
| for (const auto& port: model.ports) | ||
| { | ||
| // Can't have port with the same ID | ||
| if (std::ranges::find_if(ports, [&port](const auto& p) { return p.Id() == port.id; }) |
There was a problem hiding this comment.
In line with legacy behaviour maybe we should collect all errors.
Somethings like :
for port in model.ports {
for each port {
if duplicate id => errors.add(ObjectWithThisIdAlreadyExists);
if idNotFound => errors.add(PortTypeNotFound)
}
}
if (error) {
log
throw/exit/whatever
}
| for (const auto& port: model.ports) | ||
| { | ||
| // Can't have port with the same ID | ||
| if (std::ranges::find_if(ports, [&port](const auto& p) { return p.Id() == port.id; }) |
There was a problem hiding this comment.
Instead of find_if you can store ids in a map.
std::map<PortID, bool> already_foundId;
for port in model.ports{
if (already_foundId[port.id])) => error
already_foundId[port.id] = true;
...
src/io/inputs/model-converter/include/antares/io/inputs/model-converter/modelConverter.h
Show resolved
Hide resolved
flomnes
reviewed
Mar 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.