Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename input components to input study #58

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

tbittar
Copy link
Contributor

@tbittar tbittar commented Dec 20, 2024

Refactor the naming of input components to input study across the codebase for improved clarity and consistency. Update related functions and tests accordingly.

Copy link
Collaborator

@killian-scalian killian-scalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another idea of naming

@@ -32,10 +31,10 @@ def __init__(self, study_path: Optional[Path]):
self.study_path = resolve_path(study_path) if study_path else None
self.study: Study = read_study_local(self.study_path) if self.study_path else None # type: ignore

def convert_study_to_input_components(self) -> InputComponents:
def convert_study_to_input_study(self) -> InputStudy:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe
convert_antares_study_to_input_study ?

Copy link
Collaborator

@killian-scalian killian-scalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@tbittar tbittar merged commit 7e87d88 into main Dec 20, 2024
2 checks passed
@tbittar tbittar deleted the fix/rename-input-components-to-study branch December 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants