New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/zip mps #492

Merged

JasonMarechal25 merged 200 commits into develop from feature/zip_mps

Nov 28, 2022

Contributor

a-zakir commented Jul 29, 2022

use zipped mps

pull-request-size bot added size/L size/XL and removed size/L labels

pull-request-size bot added size/XXL size/XL and removed size/XL size/XXL labels

flomnes requested changes

View reviewed changes

Member

flomnes left a comment

Change the commit-id of submodule antares-deps to match tag 2.0.3, after its release.

tests/cpp/zip_mps/zip_mps_lib_tests.cpp Outdated Show resolved Hide resolved

sonarqubecloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
39 Code Smells

31.2% Coverage
0.0% Duplication

pull-request-size bot added size/XXL and removed size/XL labels

flomnes assigned flomnes and a-zakir

flomnes previously requested changes

View reviewed changes

src/cpp/helpers/ArchiveReader.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveReader.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

flomnes reviewed

View reviewed changes

src/cpp/helpers/ArchiveWriter.cpp Outdated Show resolved Hide resolved

a-zakir requested a review from JasonMarechal25

September 1, 2022 07:37

tbittar reviewed

View reviewed changes

src/cpp/benders/benders_mpi/BendersMPI.cpp Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/benders/benders_sequential/BendersSequential.cpp Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LauncherHelpers.cpp Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LinkProblemsGenerator.cpp Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LinkProblemsGenerator.cpp Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LinkProblemsGenerator.cpp Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LinkProblemsGenerator.cpp Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/cpp/lpnamer/problem_modifier/LinkProblemsGenerator.h Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/python/antares_xpansion/benders_driver.py Outdated Show resolved Hide resolved

tbittar reviewed

View reviewed changes

src/python/antares_xpansion/problem_generator_driver.py Outdated Show resolved Hide resolved

JasonMarechal25 force-pushed the feature/zip_mps branch from 9195347 to 4208268 Compare

September 28, 2022 08:05

a-zakir added 3 commits

September 29, 2022 15:01


          work on zipped mps

dfa8b04


          add compressed-archive reader

24d3a71


          add ArchiveWriter

deba679

a-zakir and others added 21 commits

October 7, 2022 15:29


          copy master mps to tmp before run

f4abb40


          link to antares-deps v2.0.5

478714e


          fix: avoid dangling refs

aa76378


          Merge branch 'feature/zip_mps' of https://github.com/AntaresSimulator…

5ffdbae

…Team/antares-xpansion into feature/zip_mps


          retore mps for lp_namer unit tests

36dc143


          avoid deleting SP1.mps and SP2.mps by renaming them

1d581e5


          fix smell code

22dc856


          copy zip

5df22ba


          master.mps is nor in zip archive

0c539dd


          test

d2b708c


          merge develop

21a7429


          fix VariableFileReader ctor

172059f


          Merge remote-tracking branch 'origin/develop' into feature/zip_mps

8d5f972

# Conflicts:
#	antares-version.json
#	src/python/antares_xpansion/xpansion_utils.py


          Use zip from simulator

3f818e1


          Fix post merge

8a63971


          Remove temporary code to zip data

15a1b55


          Handle ts-numbers with zip data

56b0062


          Upgrade simulator to 8.4

f838301


          Merge branch 'develop' into feature/zip_mps

118f104


          Fix post merge

914699a


          Clean up

8c4b4e7

sonarqubecloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
34 Code Smells

22.6% Coverage
0.0% Duplication

a-zakir marked this pull request as ready for review

November 28, 2022 15:45

JasonMarechal25 requested review from flomnes and tbittar

November 28, 2022 15:54

JasonMarechal25 approved these changes

View reviewed changes

a-zakir removed the request for review from flomnes

November 28, 2022 16:03

JasonMarechal25 dismissed flomnes’s stale review

November 28, 2022 16:07

Outdated review, code diverges a lot or suggestion were taken into account

JasonMarechal25 merged commit ea9f9e4 into develop

JasonMarechal25 deleted the feature/zip_mps branch

November 28, 2022 16:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels