Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/antares in memory #753

Merged
merged 173 commits into from
Sep 13, 2024
Merged

Feature/antares in memory #753

merged 173 commits into from
Sep 13, 2024

Conversation

JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented Jan 25, 2024

Introduce "study mode". A way to run xpansion and problem generation with a study folder as parameter. In this case Antares will not be run as a stand-alone but as a library by problem generation.

  • New ADRs
  • Add a "new" data set for lpnamer E2E tests: SmallTestFiveCandidates, a copy of the example provided by Xpansion.
  • Refactor test_lpnamerEndToEnd.py : when possible prefer the use multiple @parametrize instead of writing the combinations in a list.
  • Refactor test_lpnamerEndToEnd.py : copy the test data in a temporary folder and works there. Prevent creating outputs in source code.
  • Add a test case for Study mode in test_lpnamerEndToEnd.py
  • Add a new E2E test: short memory
  • Refactor ProblemGenerationExeOptionsTest to test several combinations of mutually exclusive parameters
  • In SolverFactory.cpp call Init() on solver objects before returning them. Prevent temporal coupling for Xpress solver where a call to init() was mandatory.
  • Add Antares as a build dependency

Missing pieces (every thing is open to discussion):

Following other PR:

  • Don't overly rename problem in API mode

@a-zakir
Copy link
Contributor

a-zakir commented Jan 25, 2024

there are a lot unnecessary changes in tests data, ex most (or all) *.ini files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional.
Data where missing some constraints

.github/workflows/build_centos7.yml Show resolved Hide resolved
## Decision

- Remove archive mode in launcher
- Remove file mode in launcher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donc pour debugger en step by step, file mode, il faudra lancer directement la bonne commande C++ et pas antares-xpansion-launcher -i <study> --step antares (actuellement je me sers beaucoup de cette dernière commande) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file useful ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I need to remove it

src/cpp/helpers/ArchiveReader.cpp Outdated Show resolved Hide resolved
src/cpp/lpnamer/model/ActiveLinks.cpp Outdated Show resolved Hide resolved
std::vector<int> tmp(constant.VariablesCount, 0);
std::vector<char> coltypes(constant.VariablesCount, 'C');

auto round10 = [](auto& collection) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just needed to for testing purposes. In production, we want to keep full data precision

Copy link

sonarcloud bot commented Sep 11, 2024

@JasonMarechal25 JasonMarechal25 merged commit 1cf286a into develop Sep 13, 2024
24 checks passed
@JasonMarechal25 JasonMarechal25 deleted the feature/antares_in_memory branch September 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants