[ANT-2299] Enable save/restore with xpress and enable by default #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't necessarily write an mps file anymore
This reverts commit 764fac1.
tbittar
reviewed
Oct 30, 2024
| @@ -45,6 +45,13 @@ std::function<int(XPRSprob prob, const char* filename, const char* flags)> | |||
| XPRSwritebasis = nullptr; | |||
| std::function<int(XPRSprob prob, const char* filename, const char* flags)> | |||
| XPRSreadprob = nullptr; | |||
| std::function<int(XPRSprob prob, int nr, int nc, const int mrow[], | |||
There was a problem hiding this comment.
Not related to this PR, but needed later for presolve
| @@ -10,3 +10,9 @@ void Problem::read_prob_mps(const std::filesystem::path& filename) { | |||
| std::tie(mc_year, week) = McYearAndWeek(filename); | |||
| solver_abstract_->read_prob_mps(filename); | |||
| } | |||
| void Problem::save_prob(const std::filesystem::path& filename) { | |||
There was a problem hiding this comment.
Do we need to do std::tie(mc_year, week) = McYearAndWeek(filename); similarly as in the previous function ?
There was a problem hiding this comment.
Maybe, will need to check
JasonMarechal25
commented
Nov 15, 2024
| @@ -0,0 +1,5 @@ | |||
| #include "gtest/gtest.h" | |||
There was a problem hiding this comment.
Need to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expend solver API with save_prob and restore_prob. Mirror Xpress API to save and restore problems
Coin solvers lack save/restore options. Using those method default to writing mps files