On interrupt do not attempt to apply blocks #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dvances and not just because of next block
greg7mdp
approved these changes
Dec 11, 2024
|
Note:start |
linh2931
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On shutdown the
interrupt_trx_test.pysends a SIGTERM to all processes. The test timed out #1058 because the node was stuck trying to validate a block with an infinite transaction in it. The SIGTERM interrupted the block apply but there was a queued up process block which caused it to attempt theapply_blockagain. The fix for this is actually in #1064 which added acheck_shutdown()toshould_terminate(). With thecheck_shutdown()inshould_terminate(), the node will check theapp().is_quitting()before attempting to apply a block. This prevents it from attempting to apply a block that was interrupted via SIGTERM which sets theapp().is_quitting()flag.Also added to the test a verification that head is advancing before verifying that LIB is advancing as a clearer indication that LIB is advancing after recovering from the interrupted block.
Resolves #1058