Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Fix duplication connection logic #1108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

P2P: Fix duplication connection logic #1108

wants to merge 2 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 17, 2025

The duplication logic for P2P connections was overly complicated. The node_id should be more than sufficient to distinguish between two connections.

Resolves #1092

@heifner heifner added the OCI Work exclusive to OCI team label Jan 17, 2025
greg7mdp
greg7mdp requested changes Jan 17, 2025
View reviewed changes
plugins/net_plugin/net_plugin.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
category: Enhancements
component: P2P
summary: Simplify and improve duplicate connection logic.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2P: Duplicate connections
4 participants
@heifner @ericpassmore @greg7mdp @spoonincode