allow the dev&test synchronous EOS VM OC mode without adjusting a compile time option #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jan 27, 2025
heifner
approved these changes
Jan 27, 2025
greg7mdp
approved these changes
Jan 27, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronous EOS VM OC mode is only for development & testing use, but gating it behind a compile time option means automated testing systems (like chicken dance) can't simply just pull a built binary from CI and use this mode. Now allow synchronous EOS VM OC via
wasm-runtime=eos-vm-oc-forced(will also need to seteos-vm-oc-enable=off). Thiseos-vm-oc-forcedchoice isn't documented anywhere and it's unlikely any normal user would stumble on it. Closes #1114