Do not interrupt apply_block during replay #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
|
Note:start |
greg7mdp
approved these changes
Jan 29, 2025
spoonincode
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During replay, under default conditions, no chainbase db sessions are active; therefore, do not allow interrupt of apply block. Also there is no use-case for interrupting an individual block during replay. With this PR, ctrl-c will interrupt replay between block applies.
There is no use case for interrupting an individual apply from the block log. Any "infinite" or invalid block in the block log needs to be pruned manually since there would be no way to append on to the blocklog to bypass a block. Also we do not want to auto-truncate the blocklog when ctrl-c interrupts replay. Instead the expected use-case is to continue replay on restart.
Issue introduced by: #993
Resolves #1125