Bumping Seedfinding Library Version to fix SimOre outdating issue

[AzoteGwei]

Description

Bump com.seedfinding:mc_core to 1.210.0

Related Issue

#143
#265
#296
#320
#326
#367

Same issue that reports that the OreSim has outdated.

Motivation and Context

Update com.seedfinding:mc_core to 1.210.0 can add support for 1.20.1-1.20.6,1.21

How Has This Been Tested?

Successfully builds artifacts.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• My code follows the code style of this project.
• Have you successfully ran tests with your changes locally?

P.S.

Please remember to edit the com.seedfinding:mc_core version in build.gradle to make OreSim usable

[crazymoose77756]

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

[AzoteGwei]

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

Most of issues I quoted was related to the .seed [seed] [version] command and utilities related to that would only support up to 1.20. Due to my decompiling result I found that the included version of seedfinding library matters in this process. The original commit was a wrapper of seedfinding so only bump the library version works.

Versions were defined in com.seedfinding.mccore.version.MCVersion and you could decompile the artifacts to verify this.

I’ve tested that on 1.21.1 it works operationally with the newest Meteor Dev version. And the SimOre works operationally either.

[crazymoose77756]

Definitely helpful! This should be merged, I think I was just mislead by some of the wording and inclusion of 143. But yes good fixes to those problems you mentioned.

Anyways I have started on the quest of fixing the false positives in the module, if you are interested in that too.

[RETROWSAV]

Yes this is good to update the outdated aspect, but most of those issues relate to false positives with ore sim. Which is something not fixed by this change.

Most of issues I quoted was related to the .seed [seed] [version] command and utilities related to that would only support up to 1.20. Due to my decompiling result I found that the included version of seedfinding library matters in this process. The original commit was a wrapper of seedfinding so only bump the library version works.

Versions were defined in com.seedfinding.mccore.version.MCVersion and you could decompile the artifacts to verify this.

I’ve tested that on 1.21.1 it works operationally with the newest Meteor Dev version. And the SimOre works operationally either.

Hi, can you tell me how to make oresim work for a 1.21 seed? what should i do specifically? thanks