Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.1 #384

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update to 1.21.1 #384

wants to merge 6 commits into from

Conversation

qingshu-ui
Copy link
Contributor

@qingshu-ui qingshu-ui commented Oct 15, 2024

Description

I have implemented optimizations to the logic for adding modules and commands in the project. These enhancements aim to streamline the registration process and improve overall efficiency. Additionally, I have integrated Kotlin into the project, leveraging its modern language features to enhance code readability and maintainability.

By utilizing Kotlin, I have been able to reduce boilerplate code and implement more expressive syntax, making the addition and management of modules and commands more intuitive. This integration not only simplifies the codebase but also allows for better collaboration among developers familiar with Kotlin. Overall, these updates contribute to a more robust and efficient framework for managing modules and commands within the project.

Related Issue

#371
#352
#385
#386 #387 #388

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • Have you successfully ran tests with your changes locally?

- Optimized the logic for adding modules and commands in the project.
- Integrated Kotlin to enhance code readability and maintainability.
- Reduced boilerplate code and improved expressiveness in the codebase.
@qingshu-ui qingshu-ui mentioned this pull request Oct 18, 2024
@vanvac
Copy link

vanvac commented Oct 20, 2024

yes

@MikeKamara
Copy link

How do I update it exactly?

@Orgus123
Copy link

Do you have Full version ?

@qingshu-ui
Copy link
Contributor Author

How do I update it exactly?

Latest build

@Ujhhgtg
Copy link

Ujhhgtg commented Oct 23, 2024

umm
This is obviously NOT an "update to 1.21.1" PR.
If you want to refactor that large amount of code, either open a new one or change the title.
(And it seems that your description was written by AI)

@Ujhhgtg
Copy link

Ujhhgtg commented Oct 23, 2024

Also nobody said we need kotlin.

@RuriYS
Copy link

RuriYS commented Oct 25, 2024

If you want to refactor that large amount of code, either open a new one or change the title.

Or just create an entire branch for it, separate the actual "update" and kotlin rewrite

And it seems that your description was written by AI)

Not everybody speaks English lol, it's a translator.

@Ujhhgtg
Copy link

Ujhhgtg commented Oct 26, 2024

If you want to refactor that large amount of code, either open a new one or change the title.

Or just create an entire branch for it, separate the actual "update" and kotlin rewrite

And it seems that your description was written by AI)

Not everybody speaks English lol, it's a translator.

It's not a traslator, just look at it (if you use AI a lot you find that it looks like AI) or open a random AI detector website. (btw I actually don't speak English)

@@ -38,6 +38,7 @@
"depends": {
"java": ">=16",
"minecraft": "~${mc_version}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.21 support? "minecraft": ["1.21", "~${mc_version}"],

@Starmania
Copy link
Contributor

Do you have any plans for 1.21.3/1.21.4 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants