update DrawParticles #10407
Merged
update DrawParticles #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anuken
reviewed
Jan 12, 2025
| build.x + Angles.trnsx(angle, len), | ||
| build.y + Angles.trnsy(angle, len), | ||
| particleSize * particleSizeInterp.apply(fin) * build.warmup() | ||
| Fill.poly( |
There was a problem hiding this comment.
This is a breaking change. A 12-point polygon is significantly more rendering overhead than a circle sprite and will have visual differences.
There was a problem hiding this comment.
Hide it behind a Boolean so that Circle is the default?
Anuken
reviewed
Feb 4, 2025
| build.y + Angles.trnsy(angle, len), | ||
| particleSize * particleSizeInterp.apply(fin) * build.warmup() | ||
| ); | ||
| if (poly) { |
There was a problem hiding this comment.
Code style is wrong, see CONTRIBUTING.md. You (or your editor) inserted spaces around { and after if, which is inconsistent style.
There was a problem hiding this comment.
I was getting to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
Just adds the ability for x and y offsets for the particles and the ability to change the amount of sides.
The video below shows in-game usage. Would be nice for mods.
20250110-1244-57.3701292.mp4
20250110-1306-33.3335699.mp4