Allow updateEffect spread to be customized or disabled for GenericCrafter #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i forgot to sync the branch lmao |
Anuken
reviewed
Feb 4, 2025
| @@ -40,6 +40,8 @@ public class GenericCrafter extends Block{ | |||
| public Effect craftEffect = Fx.none; | |||
| public Effect updateEffect = Fx.none; | |||
| public float updateEffectChance = 0.04f; | |||
| public boolean updateEffectSpread = true; | |||
There was a problem hiding this comment.
This doesn't need to exist, one could make the updateEffectSpreadMag 0 instead.
There was a problem hiding this comment.
good point, i didn't think of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an updateEffectSpread and updateEffectSpreadMag for customization of where the updateEffect appears on a GenericCrafter. Previously, you couldn't ensure it appears at a given location, as it would always be placed all around the sprite. By default, this does the spread and also has the same spread magnitude as before, so it's backwards-compatible.
I've read the guidelines, compiled and tested the game, and ensured that it works properly.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: