Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
While experimenting with the power diode, I found inconsistencies in its behavior.
Its purpose is to transfer power when the back power graph has a higher percentage of stored energy than the front power graph, but it doesn't actually intend to balance them that way.
For example, a fully charged large battery will transfer 50000 * (1 - 0) / 2 = 25000 energy (clamped to 4000) to a small battery. However, intuitively it should be around 3700.
This code fixes the issue. I also believe that there is no longer any need for the clamp or for dividing by 2, but it remains unchanged.
Before:
![image](https://private-user-images.githubusercontent.com/56217284/408818304-c6e863e4-dcb1-442c-93e3-50d4852f08f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgzMDQtYzZlODYzZTQtZGNiMS00NDJjLTkzZTMtNTBkNDg1MmYwOGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4OTJiMjYzOGJiYjA1YWFkM2E0ODZiYjJjM2IxOGM0MmJiM2ZmMGVhMGI1NGUwZmJkZmJmYTU1YTliYzAyNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TSw8mZHsEnNE2HILvy4n3qQnVbdnLAb3COJfR05efMM)
![image](https://private-user-images.githubusercontent.com/56217284/408818318-1a8f22bd-68ae-43cf-a0bf-b2b756a30039.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgzMTgtMWE4ZjIyYmQtNjhhZS00M2NmLWEwYmYtYjJiNzU2YTMwMDM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkYTZkYjhjZDNiYjY2YTBjNTU3NDdiZTJkYTcxMDlkYTZmYTViMzFlNGQyMzE1OTY3NTEyYjhmNmUyNzE0MTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PmRZzKjoCiX9XJ-9rLE27iESXT3Ugoo1rtvEi4VFINo)
![image](https://private-user-images.githubusercontent.com/56217284/408818337-7b9f2d51-e345-42e2-a0d4-81277672f58e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgzMzctN2I5ZjJkNTEtZTM0NS00MmUyLWEwZDQtODEyNzc2NzJmNThlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5NGMwNWNlNTNhOWM2NGIyODRjNjI2NzJhMGJkMGU3MmQxY2JjOGU4YjExMDJlODgxY2IxMzM1MmYyMGUyNzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fZbN7jP1eTul1KubzjfGI0j6uSgY5CsGdrXiV9ebkiI)
After:
![image](https://private-user-images.githubusercontent.com/56217284/408818209-78406be3-ac20-4f5c-9756-2cfec783d71c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgyMDktNzg0MDZiZTMtYWMyMC00ZjVjLTk3NTYtMmNmZWM3ODNkNzFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0NjI1NzgyMjI0NjE3ZDc5M2YxN2RlMGNmZjRhNjM3OWNjMzY3NjNlZmVhNjMzYWE1YWI2MzU5NDc5ODE3YjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FNpTaZnSOLH7RwkyFLm8WOJeFZvLo6BJEkNKVggfG50)
![image](https://private-user-images.githubusercontent.com/56217284/408818220-185acf4d-41d7-410c-8651-a2b2572d5df2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgyMjAtMTg1YWNmNGQtNDFkNy00MTBjLTg2NTEtYTJiMjU3MmQ1ZGYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjNThmOGYyNjdhNDMyYjYyM2Q0NzY0NDE1MzEzN2M5NGQ3Yzc1MzQ0ZjMxZDFhYWU5NGI4MDQwZThhMzA4OGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ElU7g61cIb_AfYsaecof4VqWCyHWvQiDOqpcv-1AOaQ)
![image](https://private-user-images.githubusercontent.com/56217284/408818224-335d7297-9061-49a3-8c74-16f8b5642b98.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTkwNDIsIm5iZiI6MTczOTAxODc0MiwicGF0aCI6Ii81NjIxNzI4NC80MDg4MTgyMjQtMzM1ZDcyOTctOTA2MS00OWEzLThjNzQtMTZmOGI1NjQyYjk4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyNDU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk4ZWQ3NjU1YjkxYTkwNzA4ZGVkZjkxN2I4MWUzMjQ5NWUzOGQ2ODc4OGI1MWU2ODYxZGM3NGEzNDkwNDBlMTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7LsCmyNIXA9Afasxbiq2SdUIPIG-iZN2CRc8sdWKPbE)