fix: handle new fields from contract-creation API response #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@banteg (adding since you implemented the original) |
antazoey
changed the title
fubuloubu
approved these changes
Nov 25, 2024
fubuloubu
approved these changes
Nov 26, 2024
|
merging, as this is good. However tests may fail because of annoying Infura issue I am debugging or maybe their servers are down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Was getting errors with some responses from Etherscan's API on some networks.
This adjusts to handle these new fields and makes less subject to breaking in the future.
How I did it
How to verify it
Checklist