Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout/FirstArrayElementIndentation-20240209233127 #914

Merged
merged 4 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 15 additions & 27 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 200`
# on 2023-10-11 12:02:42 UTC using RuboCop version 1.57.0.
# `rubocop --auto-gen-config --exclude-limit 180`
# on 2024-02-09 23:31:57 UTC using RuboCop version 1.60.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -154,7 +154,7 @@ Layout/EmptyLineBetweenDefs:
- 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
- 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'

# Offense count: 56
# Offense count: 55
# This cop supports safe autocorrection (--autocorrect).
Layout/EmptyLines:
Exclude:
Expand Down Expand Up @@ -192,7 +192,7 @@ Layout/EmptyLinesAroundAttributeAccessor:
Exclude:
- 'lib/apipie/configuration.rb'

# Offense count: 92
# Offense count: 91
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: empty_lines, no_empty_lines
Expand All @@ -213,7 +213,6 @@ Layout/EmptyLinesAroundBlockBody:
- 'spec/lib/apipie/extractor/writer_spec.rb'
- 'spec/lib/apipie/file_handler_spec.rb'
- 'spec/lib/apipie/generator/swagger/param_description/composite_spec.rb'
- 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb'
- 'spec/lib/apipie/param_description_spec.rb'
- 'spec/lib/apipie/param_group_spec.rb'
- 'spec/lib/apipie/validator_spec.rb'
Expand Down Expand Up @@ -314,15 +313,6 @@ Layout/ExtraSpacing:
- 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb'
- 'spec/lib/swagger/swagger_dsl_spec.rb'

# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Layout/FirstArrayElementIndentation:
Exclude:
- 'spec/dummy/app/controllers/pets_controller.rb'
- 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'

# Offense count: 38
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.
Expand Down Expand Up @@ -454,7 +444,7 @@ Layout/SpaceAfterColon:
Exclude:
- 'spec/dummy/app/controllers/included_param_group_controller.rb'

# Offense count: 42
# Offense count: 41
# This cop supports safe autocorrection (--autocorrect).
Layout/SpaceAfterComma:
Exclude:
Expand Down Expand Up @@ -490,8 +480,9 @@ Layout/SpaceAfterNot:

# Offense count: 142
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals.
# SupportedStylesForExponentOperator: space, no_space
# SupportedStylesForRationalLiterals: space, no_space
Layout/SpaceAroundOperators:
Exclude:
- 'app/controllers/apipie/apipies_controller.rb'
Expand Down Expand Up @@ -726,21 +717,18 @@ Lint/UnderscorePrefixedVariableName:
- 'lib/apipie/application.rb'
- 'lib/apipie/dsl_definition.rb'

# Offense count: 26
# Offense count: 22
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
Exclude:
- 'lib/apipie/configuration.rb'
- 'lib/apipie/extractor/collector.rb'
- 'lib/apipie/extractor/recorder.rb'
- 'lib/apipie/param_description.rb'
- 'lib/apipie/resource_description.rb'
- 'lib/apipie/rspec/response_validation_helper.rb'
- 'lib/tasks/apipie.rake'
- 'spec/controllers/users_controller_spec.rb'
- 'spec/lib/apipie/apipies_controller_spec.rb'
- 'spec/lib/apipie/extractor_spec.rb'
- 'spec/lib/swagger/swagger_dsl_spec.rb'
- 'spec/spec_helper.rb'

Expand Down Expand Up @@ -802,7 +790,7 @@ Metrics/MethodLength:
Metrics/ModuleLength:
Max: 119

# Offense count: 4
# Offense count: 5
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
MaxOptionalParameters: 5
Expand Down Expand Up @@ -974,7 +962,7 @@ RSpec/BeforeAfterAll:
Exclude:
- 'spec/controllers/users_controller_spec.rb'

# Offense count: 53
# Offense count: 54
# Configuration parameters: Prefixes, AllowedPatterns.
# Prefixes: when, with, without
RSpec/ContextWording:
Expand Down Expand Up @@ -1141,7 +1129,7 @@ RSpec/MessageSpies:
RSpec/MultipleExpectations:
Max: 19

# Offense count: 160
# Offense count: 163
# Configuration parameters: AllowSubject.
RSpec/MultipleMemoizedHelpers:
Max: 15
Expand All @@ -1166,7 +1154,7 @@ RSpec/NamedSubject:
- 'spec/lib/swagger/rake_swagger_spec.rb'
- 'spec/lib/swagger/swagger_dsl_spec.rb'

# Offense count: 96
# Offense count: 97
# Configuration parameters: AllowedGroups.
RSpec/NestedGroups:
Max: 6
Expand Down Expand Up @@ -1293,7 +1281,7 @@ Rails/NegateInclude:
- 'lib/apipie/extractor/writer.rb'
- 'spec/spec_helper.rb'

# Offense count: 7
# Offense count: 6
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Include.
# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
Expand Down Expand Up @@ -1921,7 +1909,7 @@ Style/StringConcatenation:
- 'lib/apipie/application.rb'
- 'lib/apipie/extractor/writer.rb'

# Offense count: 1214
# Offense count: 1229
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand Down Expand Up @@ -2021,7 +2009,7 @@ Style/TrailingCommaInArrayLiteral:
- 'spec/controllers/users_controller_spec.rb'
- 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'

# Offense count: 4
# Offense count: 5
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyleForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
Expand Down
8 changes: 4 additions & 4 deletions spec/dummy/app/controllers/pets_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,8 @@ def returns_response_with_valid_array
result = {
a_number: 3,
array_of_objects: [
{number1: 1, number2: 2},
{number1: 10, number2: 20}
{number1: 1, number2: 2},
{number1: 10, number2: 20}
]
}
render :json => result
Expand All @@ -387,8 +387,8 @@ def returns_response_with_invalid_array
result = {
a_number: 3,
array_of_objects: [
{number1: 1, number2: 2},
{number1: 10, number2: "this should have been a number"}
{number1: 1, number2: 2},
{number1: 10, number2: "this should have been a number"}
]
}
render :json => result
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
class Pet
def self.describe_own_properties
[
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop(:animal_type, 'string', {:description => 'Type of pet', :values => %w[dog cat iguana kangaroo]}),
Apipie::additional_properties(false)
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop(:animal_type, 'string', {:description => 'Type of pet', :values => %w[dog cat iguana kangaroo]}),
Apipie::additional_properties(false)
]
end
end
Expand All @@ -26,14 +26,14 @@ def self.describe_own_properties
class PetWithMeasurements
def self.describe_own_properties
[
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop('animal_type', 'string', {:description => 'Type of pet', :values => %w[dog cat iguana kangaroo]}),
Apipie::prop(:pet_measurements, 'object', {}, [
Apipie::prop(:weight, 'number', {:description => "Weight in pounds" }),
Apipie::prop(:height, 'number', {:description => "Height in inches" }),
Apipie::prop(:num_legs, 'number', {:description => "Number of legs", :required => false }),
Apipie::additional_properties(false)
])
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop('animal_type', 'string', {:description => 'Type of pet', :values => %w[dog cat iguana kangaroo]}),
Apipie::prop(:pet_measurements, 'object', {}, [
Apipie::prop(:weight, 'number', {:description => "Weight in pounds" }),
Apipie::prop(:height, 'number', {:description => "Height in inches" }),
Apipie::prop(:num_legs, 'number', {:description => "Number of legs", :required => false }),
Apipie::additional_properties(false)
])
]
end
end
Expand All @@ -44,11 +44,11 @@ def self.describe_own_properties
class PetWithManyMeasurements
def self.describe_own_properties
[
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop(:many_pet_measurements, 'object', {is_array: true}, [
Apipie::prop(:weight, 'number', {:description => "Weight in pounds" }),
Apipie::prop(:height, 'number', {:description => "Height in inches" }),
])
Apipie::prop(:pet_name, 'string', {:description => 'Name of pet', :required => false}),
Apipie::prop(:many_pet_measurements, 'object', {is_array: true}, [
Apipie::prop(:weight, 'number', {:description => "Weight in pounds" }),
Apipie::prop(:height, 'number', {:description => "Height in inches" }),
])
]
end
end
Expand Down