-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 72 fix deprecation warn #948
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ekohl 's comment.
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@Migoo the comment was applicable to to all lines changed and I just didn't want to repeat myself. Could you please apply it everywhere consistently? |
My bad ! I just push for all deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me so I just approved the tests to see if CI agrees.
@mathieujobin do you agree this is now good to go? I also think we should squash the commits on merge.
Looking at the tests, I see we're not testing on Rails 7.2 so perhaps it should also be added: apipie-rails/.github/workflows/build.yml Line 11 in 62b24b6
We can also ignore the Ruby 3.4 failure in this PR, but we should address that as well as change it to Ruby 3.4 final now that's out. |
Fix deprecation method ActiveSupport::Deprecation.warn. Replaced with ActiveSupport::Deprecation.new.warn