-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD-224 Fix errors #99
base: develop
Are you sure you want to change the base?
Conversation
@@ -31,7 +31,7 @@ export default function Entry(props) { | |||
<> | |||
{ledgerId && ( | |||
<tr> | |||
<td className="blue-link-text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
его точно удалить нужно, просто не похоже на фикс варнинга
componentWillReceiveProps() { | ||
this.getAskOrders(); | ||
this.getBidOrders(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в целом можно прогнать проект через https://github.com/reactjs/react-codemod#rename-unsafe-lifecycles для переименования устаревших методов. Они периодически всречаются
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я согласна, что надо это сделать, но боюсь что может что-то в логике поламаться
Ну и лучше это сделать отдельной таской
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по поводу отдельной таски - это хорошее замечание. Более наглядно и проще что-то поправить, если сломается
@@ -55,7 +55,9 @@ class MandatoryApproval extends React.Component { | |||
<div className="modal-box"> | |||
<form className="modal-form"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в данном файле имеются не используемые импорты
function Stage(number) { | ||
if (number === "0") { | ||
return "Registration"; | ||
} else if (number === "1") { | ||
return "Processing"; | ||
} else if (number === "4") { | ||
return "Expired"; | ||
} else if (number === "5") { | ||
return "Done"; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch сюда очень просится)
No description provided.