Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document TelemetrySource property of the ExecutionRejectedException #2355

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Oct 24, 2024

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Added documentation about the TelemetrySource property

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (6f7edf8) to head (d923761).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         313      313           
  Lines        7482     7482           
  Branches     1125     1125           
=======================================
  Hits         6392     6392           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.43% <ø> (+0.02%) ⬆️
macos 85.43% <ø> (ø)
windows 85.43% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/rate-limiter.md Outdated Show resolved Hide resolved
docs/strategies/rate-limiter.md Outdated Show resolved Hide resolved
docs/strategies/rate-limiter.md Outdated Show resolved Hide resolved
docs/strategies/rate-limiter.md Outdated Show resolved Hide resolved
docs/strategies/timeout.md Outdated Show resolved Hide resolved
docs/strategies/timeout.md Outdated Show resolved Hide resolved
docs/strategies/timeout.md Outdated Show resolved Hide resolved
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the "please note" prefix from line 158 too?

Just one missed comment for rate-limiter.md.

@martincostello martincostello enabled auto-merge (squash) October 24, 2024 11:34
@martincostello martincostello merged commit 1ec4767 into App-vNext:main Oct 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants