Skip to content

Commit

Permalink
Fix handling of to addresses on graduate school email notifications. …
Browse files Browse the repository at this point in the history
…The to field can be a comma separated list, be sure we break it apart accordingly.
  • Loading branch information
jlbooker committed Apr 3, 2017
1 parent 3138e76 commit dfe91d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion class/Email/CancelInternshipNotice.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected function buildMessage()

// CC the graduate school (for grad level) or the registrar's office (for undergrad level)
if($this->internship->isGraduate()){
$this->cc[] = $this->emailSettings->getGraduateRegEmail();
$this->cc[] = explode(',', $this->emailSettings->getGraduateRegEmail()); // NB: Setting is a comma separated array
} else {
$this->cc[] = $this->emailSettings->getRegistrarEmail();
}
Expand Down
3 changes: 1 addition & 2 deletions class/Email/GradSchoolNotificationEmail.php
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ protected function buildMessage()
$intlSubject = '';
}

$emails = $this->emailSettings->getGradSchoolEmail();
$this->to = explode(',', $emails);
$this->to = explode(',', $this->emailSettings->getGradSchoolEmail()); // NB: Setting is a comma separated array

$this->subject = 'Internship Approval Needed: ' . $intlSubject . '[' . $this->internship->getBannerId() . '] ' . $this->internship->getFullName();
}
Expand Down

0 comments on commit dfe91d9

Please sign in to comment.