Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup check for 'magic_quotes' config #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlbooker
Copy link
Contributor

The Setup class currently checks the PHP configuration for the 'magic_quotes' feature to ensure it's turned off. The get_magic_quotes_gpc and get_magic_quotes_runtime methods are deprecated in php 7.4 and removed in php 8. This currently causes the installer to fail under PHP 7.4+. The magic_quotes feature was disabled in v5.4, and now the methods to test for it are also being removed, so this check is no longer needed.

References:
https://www.php.net/manual/en/function.get-magic-quotes-gpc.php
https://www.php.net/manual/en/function.get-magic-quotes-runtime.php
https://www.php.net/manual/en/migration74.deprecated.php
https://www.php.net/manual/en/migration80.incompatible.php

…s_*' methods are deprecated in php 7.4 and removed in php 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant