Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MotionExtractor module bug fix #267

Merged
merged 7 commits into from
Aug 24, 2023
Merged

MotionExtractor module bug fix #267

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e09bb4
Taking size from getSerialize() now
mohammedzakikochargi Jul 18, 2023
3ab78b3
Updated code to use serialized size
mohammedzakikochargi Jul 18, 2023
3bb7bba
Merge branch 'main' into MotionVectorExtractorFix
mraduldubey Aug 18, 2023
c2c8dc3
Merge branch 'main' into MotionVectorExtractorFix
mraduldubey Aug 18, 2023
62afbab
Merge branch 'main' into MotionVectorExtractorFix
mraduldubey Aug 23, 2023
ee40723
Merge branch 'main' into MotionVectorExtractorFix
mraduldubey Aug 23, 2023
5d8777a
Merge branch 'main' into MotionVectorExtractorFix
mraduldubey Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions base/src/MotionVectorExtractor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ int DetailFfmpeg::decodeAndGetMotionVectors(AVPacket* pkt, frame_container& fram
{
DrawingOverlay drawingOverlay;
drawingOverlay.add(&compositeOverlay);

outFrame = makeFrameWithPinId(sideData->size, motionVectorPinId);
memcpy(outFrame->data(), sideData->data, sideData->size);
auto serializedSize = drawingOverlay.mGetSerializeSize();
outFrame = makeFrameWithPinId(serializedSize, motionVectorPinId);
memcpy(outFrame->data(), sideData->data, serializedSize);
drawingOverlay.serialize(outFrame);
frames.insert(make_pair(motionVectorPinId, outFrame));
}
Expand Down Expand Up @@ -284,7 +284,7 @@ void DetailOpenH264::getMotionVectors(frame_container& frames, frame_sp& outFram
{
DrawingOverlay drawingOverlay;
drawingOverlay.add(&compositeOverlay);
auto mvSize = static_cast<size_t>(mMotionVectorSize);
auto mvSize = drawingOverlay.mGetSerializeSize();
outFrame = makeframe(outFrame, mvSize, motionVectorPinId);
drawingOverlay.serialize(outFrame);
frames.insert(make_pair(motionVectorPinId, outFrame));
Expand Down
Loading