Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk build for linux #277

Merged
merged 9 commits into from
Aug 29, 2023
Merged

gtk build for linux #277

merged 9 commits into from
Aug 29, 2023

Conversation

venkat0907
Copy link
Contributor

@venkat0907 venkat0907 commented Aug 1, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #271

Description

added "gtk" dependency in opencv for Linux , now we can use ImageViewer module on Linux and can render through webcam

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

NO

Type Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Test Results Linux

    1 files      1 suites   10m 23s ⏱️
303 tests 230 ✔️ 73 💤 0
230 runs  157 ✔️ 73 💤 0

Results for commit 748a97e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Test Results Windows-cuda

    1 files  ±0      1 suites  ±0   12m 43s ⏱️ ±0s
400 tests +1  293 ✔️ ±0  107 💤 +1  0 ±0 
293 runs  ±0  186 ✔️  - 1  107 💤 +1  0 ±0 

Results for commit 748a97e. ± Comparison against base commit 080ccf8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Test Results Win-nocuda

    1 files  ±0      1 suites  ±0   10m 44s ⏱️ +3s
299 tests +1  230 ✔️ ±0  69 💤 +1  0 ±0 
230 runs  ±0  161 ✔️  - 1  69 💤 +1  0 ±0 

Results for commit 748a97e. ± Comparison against base commit 080ccf8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Test Results Linux-CudaT

    1 files  ±0      1 suites  ±0   10m 25s ⏱️ -1s
404 tests +1  237 ✔️ ±0  167 💤 +1  0 ±0 
237 runs  ±0    70 ✔️  - 1  167 💤 +1  0 ±0 

Results for commit 748a97e. ± Comparison against base commit 080ccf8.

♻️ This comment has been updated with latest results.

@mraduldubey
Copy link
Collaborator

Lets try a little more on ARM before making a definitive decision

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test Results Linux_ARM64

    1 files      1 suites   10m 45s ⏱️
426 tests 262 ✔️ 164 💤 0
262 runs    98 ✔️ 164 💤 0

Results for commit 748a97e.

♻️ This comment has been updated with latest results.

@venkat0907 venkat0907 changed the title ImageViewerModuleLinuxFix gtk build for linux Aug 17, 2023
Vinayak-YB
Vinayak-YB previously approved these changes Aug 23, 2023
Copy link
Collaborator

@Vinayak-YB Vinayak-YB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes.

Copy link
Collaborator

@Vinayak-YB Vinayak-YB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtk build - imageviewer is tested on linux

@mraduldubey mraduldubey mentioned this pull request Aug 29, 2023
3 tasks
@mraduldubey mraduldubey merged commit 0d03309 into main Aug 29, 2023
@mraduldubey mraduldubey deleted the ImageViewerFix branch August 29, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageViewer Module Improvement
3 participants