Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericRendererModule #284

Merged
merged 6 commits into from
Aug 16, 2023
Merged

GenericRendererModule #284

merged 6 commits into from
Aug 16, 2023

Conversation

venkat0907
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #282

Description

Merged Eglrenderer module into imageviewer module now we have one renderer module , if device is arm and memtype is dma it uses egl for rendering else it uses imageviewer(opencv->imshow)

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

NO

Type Choose one: Enhancement

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux-CudaT

    1 files  ±0      1 suites  ±0   10m 23s ⏱️ -1s
389 tests +4  228 ✔️ ±0  161 💤 +4  0 ±0 
228 runs  ±0    67 ✔️  - 4  161 💤 +4  0 ±0 

Results for commit 32003db. ± Comparison against base commit abddb05.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux_ARM64

    1 files  ±0      1 suites  ±0   10m 59s ⏱️ ±0s
413 tests +4  256 ✔️ ±0  157 💤 +4  0 ±0 
256 runs  ±0    99 ✔️  - 4  157 💤 +4  0 ±0 

Results for commit 32003db. ± Comparison against base commit abddb05.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Windows-cuda

    1 files      1 suites   12m 22s ⏱️
385 tests 287 ✔️ 98 💤 0
287 runs  189 ✔️ 98 💤 0

Results for commit 32003db.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Linux

    1 files  ±0      1 suites  ±0   10m 21s ⏱️ ±0s
298 tests +4  226 ✔️ ±0  72 💤 +4  0 ±0 
226 runs  ±0  154 ✔️  - 4  72 💤 +4  0 ±0 

Results for commit 32003db. ± Comparison against base commit abddb05.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results Win-nocuda

    1 files  ±0      1 suites  ±0   10m 45s ⏱️ +7s
294 tests +4  226 ✔️ ±0  68 💤 +4  0 ±0 
226 runs  ±0  158 ✔️  - 4  68 💤 +4  0 ±0 

Results for commit 32003db. ± Comparison against base commit abddb05.

♻️ This comment has been updated with latest results.

base/include/ImageViewerModule.h Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
base/src/ImageViewerModule.cpp Outdated Show resolved Hide resolved
@kumaakh kumaakh merged commit 16b7548 into main Aug 16, 2023
17 of 19 checks passed
@kumaakh kumaakh deleted the GenericRenderermodule branch August 16, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate all renderers in the ImageViewer Module
4 participants