Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Features: Quick Flags; Mass Labeler #827

Open
wants to merge 52 commits into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Nov 16, 2022

continuation of #771

Description

This creates a script to quickly toggle the mature content community labels on your original posts posts and reblogs.

It implements a Quick Tags-style dropdown that lets the user label an individual post and a bulk-edit sidebar option and modal form to easily retroactively flag every post with certain tags or the user's entire blog.

Testing steps

Co-authored-by: April Sylph <[email protected]>
@marcustyphoon marcustyphoon changed the title implement fast community label dropdown New script: Quick Flags Dec 13, 2022
@marcustyphoon marcustyphoon changed the title New script: Quick Flags New Script: Quick Flags Feb 4, 2023
@marcustyphoon marcustyphoon marked this pull request as ready for review February 13, 2023 23:57
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented May 5, 2023

I was going to update this to use the mass post editor endpoint (https://www.tumblr.com/changes/715595761003429888/tuesday-april-25th-2023) to perform the edits in batches of 100, but the page actually uses a legacy SVC endpoint at the moment, which we can't realistically make use of.

Edit: It was fixed not to use internal blog IDs, but it currently overwrites label categories rather than adding to them. This makes it difficult to use in a bulk scenario, as multiple posts which begin with different categories cannot be edited correctly in the same API request.

src/util/mega_editor.js Outdated Show resolved Hide resolved
@marcustyphoon marcustyphoon marked this pull request as draft August 30, 2023 05:09
@marcustyphoon
Copy link
Collaborator Author

The mass post editor continues to overwrite rather than add, unlike what its UI suggests. Using its endpoint correctly would therefore require sorting posts by their current labels, which I actually am happy to code.

This is, on the one hand, a lot of coding effort (sure) and testing/maintenance effort (problematic) for a feature that I would be surprised if many people used.

On the other hand, I think this existing is good for the completeness of the ecosystem; if we really want to encourage people to community label their content comprehensively, better tools to do that seem like good messaging.

@AprilSylph AprilSylph linked an issue Apr 8, 2024 that may be closed by this pull request
@AprilSylph AprilSylph self-requested a review April 29, 2024 07:45
Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be split into two features. "Quick Flags" should be the feature with the control buttons on individual posts, while the mass labeller should be, er, probably yeah that. "Mass Labeller".

@marcustyphoon
Copy link
Collaborator Author

👍 I feel like if I ever have a baby I'll need to message you for naming suggestions.

I guess this selector should be a util, huh. or actually the whole editable-posts-get-buttons thing should be exported from control_buttons.js
could instead be top level await, but that would make scripts silently fail to load on any error which I vehemently hate
@marcustyphoon marcustyphoon changed the title New Script: Quick Flags New Scripts: Quick Flags; Mass Labeler Aug 19, 2024
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Sep 9, 2024

@marcustyphoon marcustyphoon changed the title New Scripts: Quick Flags; Mass Labeler New Features: Quick Flags; Mass Labeler Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to community label a reblog
2 participants