[pull] master from curl:master #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Also, CURLOPT_TCP_FASTOPEN is for TCP only. Closes #14852
Bumped to 8.10.1 for now
Do not give up connect on servers that are in draining state. This might indicate the QUIC server restarting and the UDP packet routing still hitting the instance shutting down. Instead keep on connecting until the overall TIMEOUT fires. Closes #14863
Modern debian reports a soft limit of 134217724 which makes this test run for minutes to allocate all file descriptors. Impose a cap of 256k, so we do not run this tests on systems with larger rlimits. Closes #14857
Adds -e to runtests for using the event-based API in the tool. Closes #14876
OpenSSL must be selected (manually or by default) and detected for `USE_OPENSSL_QUIC=ON` to work. This was documented before this patch, but with CMake it was possible to use `USE_OPENSSL_QUIC=ON` without an explicit or default `CURL_USE_OPENSSL=ON`, leading to a confused internal state. Fix by checking the QUIC condition early, showing a warning if enabled without OpenSSL, and ignoring QUIC in such case. Also: Fix casing of OpenSSL in option description. Ref: #14866 Closes #14872
The configuration data compared to `candidate` comes from `data`, not `conn`. This commit fixes the docstring to reflect this. Closes #14887
By keeping the headers in memory until we know the target file name, then output them all. Previously this option combination would cause an error. Add test 1310 and 1492 to verify. Adjusted test 1460 to work in the new conditions. Closes #15110
Pointed out by CodeSonar Closes #15117
For all tests using -O that were previously relying on a debug build and the CURL_TESTDIR environment variable, use the plain --output-dir option instead so that they can run proper in non-debug builds. Closes #15114
Instead of calling the shell and external tools, rely on Perl functions like `Cwd::getcwd()`, `Cwd::abs_path()`, `Cygwin::posix_to_win_path()`, `Cygwin::win_to_posix_path()` to retrieve the current directory and convert between POSIX and Windows formats. This adds native Windows Perl support, avoids most failure modes and makes format guessing and other internal functions unnecessary. Also: - delete unused `sys_native_path()`. - delete redundant `normalize_path()` because Perl `abs_path()` already does it. Cherry-picked from #14949 Closes #15111
This needs the version in the GHA context, so move those back from external file `VERSIONS`. Also move back `VERSIONS` content in it previous place to `.circleci/config.yml`. Update renovate config. Renovate bot should keep updating the wolfSSL version, but from now on not in one, but two files. Follow-up to 820afa2 #15030 Follow-up to 73a3602 Closes #15130
Generate the certificate serial numbers automatically instead of doing from shell (or Perl earlier). Fixes intermittent CI failures due to the shell-based random generator generating the same serial number twice: ``` $ openssl ca -config EdelCurlRoot-ca.cnf -revoke Server-localhost0h-sv.crt Using configuration from EdelCurlRoot-ca.cnf ERROR:Already revoked, serial number 66FDB23A make: *** [../../../tests/certs/Server-localhost0h-sv.pem] Error 1 ``` https://github.com/curl/curl/actions/runs/11151401083/job/30994755798?pr=15128#step:10:498 Follow-up to fa461b4 #14486 Follow-up to fa69b41 #13307 Closes #15129
... instead of malloc and "manual" buffer stuffing Closes #15126
booleans should use the type 'bool' and set the value to TRUE/FALSE non-booleans should not be 'bool' and should not set the value to TRUE/FALSE Closes #15123
Previously this document stated we would do it after February, but now it will be done already for the first January 2025 release. The reason being that since we decided to deprecate hyper, the degradation speed has increased as now no one bothers to fix issues in the hyper side of things. Also: not a single soul has yet spoken up in favor of keeping the support. Closes #15135
As a workaround for the latest Debian image missing the necessary keys: ``` No signatures for debian:testing-20240926-slim Administrative keys for debian:testing-20240926-slim Repository Key: 5717dcd81d9fb5b73aa15f2d887a6a0de543829ab9b2d411acce9219c2f8ba3a Root Key: 575d013f89e3cbbb19e0fb06aa33566c22718318e0c9ffb1ab5cc4291e07bf84 No valid trust data for testing-20240926-slim ``` https://github.com/curl/curl/actions/runs/11067644862/job/30752034560?pr=15065 Ref: curl/curl-for-win@0ad1ad5
Fixes: ``` error: https://github.com/google/brotli/archive/v1.1.0.tar.gz: WinHttpSendRequest failed with exit code 10106 ``` Apply workaround: microsoft/vcpkg#41199 (comment) Bug commit: microsoft/vcpkg-tool@d3fc357#diff-33cf7c311a76d4a838f91b078c2f8cbc984557379f7b345a268ec6deb665a91eR666-R675 Fix commit: microsoft/vcpkg-tool@3122da7 Fix PR: microsoft/vcpkg-tool#1501 Fixes #15128 Reported-by: Viktor Szakats Closes #15133
`Curl_bufq_unwrite()` used the head instead of the tail chunk to shrink the bufq's content. Fix this and add test case that checks correct behaviour. Amended test 2601 accordingly. Reported-by: Chris Stubbs Closes #15136
Test failed on some Windows CI and log files did not really tell why. Add more output. Closes #15140
Due to timings on paused response receive, the error code may vary due to the location where it is detected that the server closed the transfer prematurely. Be more lenient in always allowing PARTIAL_FILE as ok. Closes #15138
Since OpenSSL does its own send/recv internally, we may miss the moment to populate the x509 store right before the server response. Do it instead before we start the handshake, at the loss of the time to set this up. Closes #15137
We have not used Travis for years. The Debian one appears on my dev machine since a while back. Closes #15142
As the parsing and address "regeneration" are done anyway, we might as well use the updated version in the result and thereby A) get a normalized (and lower cased) version of the address and B) avoid a strcpy(). Updated test 1560 to verify. Closes #15143
Since we see Windows fails of 1915, add tracing and a connect timeout. The test uses a port no one is supposed to listen on, but Windows has this weird wait logic. So, set a short timeout. Closes #15107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )