Change redeem error handling to avoid infinite loop on successful redeem #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we looped when a redeem failed, but this creates a race condition with other sources of redeem, eg auto redeem or redeem by another account. In that case the status never gets checked so an infinite loop occurs trying to redeem.
As a fix we allow the upper loop to be responsible for the status checking, and signal an error that should be retried forever using a new error type.
See here for example of failing test: https://github.com/ArbitrumFoundation/governance/actions/runs/11628393590/job/32383468289