Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redeem error handling to avoid infinite loop on successful redeem #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yahgwai
Copy link
Collaborator

@yahgwai yahgwai commented Nov 1, 2024

Previously we looped when a redeem failed, but this creates a race condition with other sources of redeem, eg auto redeem or redeem by another account. In that case the status never gets checked so an infinite loop occurs trying to redeem.

As a fix we allow the upper loop to be responsible for the status checking, and signal an error that should be retried forever using a new error type.

See here for example of failing test: https://github.com/ArbitrumFoundation/governance/actions/runs/11628393590/job/32383468289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants