Sc rotation update #322
Open
Sc rotation update #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yahgwai
commented
Nov 26, 2024
yahgwai
commented
- checks that new member in rotation is not a nominee in the same way we already check for contender
- records the address that was rotated to to avoid race conditions in removal/replace
gzeoneth
reviewed
Dec 27, 2024
| function memberRotatedTo(address _member) internal view returns (address) { | ||
| if ( | ||
| rotatedTo[_member] != address(0) | ||
| && !SecurityCouncilMgmtUtils.isInArray(_member, getBothCohorts()) |
There was a problem hiding this comment.
Instead of checking if it is in current cohorts, we can wipe the new member's rotatedTo entry whenever a new member joined. This allow us to have a clean rotatedTo mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.