Modified reloadModifiers() to wrap the content in a delayed task to fix a bug #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified reloadModifiers() to wrap the content in a delayed task and ensure the player's health after reload is the same as it was before reloadPlayer() was called.
Make sure that currentHealth does not exceed the new maxHealth in edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a hit that should kill you with your normal health, let's say 100 damage, but you have 500 health from the plugin for example and with this hit you level up a skill, calling reloadModifiers() is bugged and kills you. If the damage is not lethal, the damage is also miscalculated and you are left with only 20hp.
A video showing the bug:
2025-01-02.00-41-43.mp4
The bug "patched":
2025-01-02.00-47-45.mp4