Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block detail pagination #1175

Merged
merged 4 commits into from
Feb 6, 2025
Merged

feat: block detail pagination #1175

merged 4 commits into from
Feb 6, 2025
+69 −3

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jan 30, 2025 •
edited
Loading

Summary

https://app.clickup.com/t/86dvvnj05

This is for mainnet/devnet so you'll need database access for those

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

ItsANameToo
ItsANameToo requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap the previous <> next urls please

@ItsANameToo ItsANameToo merged commit bd442d6 into develop Feb 6, 2025
9 checks passed
@ItsANameToo ItsANameToo deleted the feat/block-detail-pagination branch February 6, 2025 14:23
@ItsANameToo ItsANameToo added this to the 2.31.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
2.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarnsley @ItsANameToo