Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: notifications dropdown dark mode styling #1041

Open
wants to merge 4 commits into
base: feat/evm
Choose a base branch
from
Open

refactor: notifications dropdown dark mode styling #1041

wants to merge 4 commits into from
+46 −66

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Mar 10, 2025 •
edited
Loading

[notifications] update dark mode styling

Summary

  • Dashed border has been added to dark mode rows in the notifications dropdown.
  • Paddings and margins have been adjusted for notifications dropdown to match the designs.
  • Snapshots have been updated to support these changes in tests.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev added this to the mainsail-evm milestone Mar 10, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Mar 10, 2025 4:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
mainsail-evm
Development

Successfully merging this pull request may close these issues.
1 participant
@patricio0312rev