Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle from/to addresses in multiview (desktop views) #927

Draft
wants to merge 5 commits into
base: refactor/handle-from-to-addresses-in-multi-view-mobile
Choose a base branch
from

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Jan 30, 2025

[portfolio] handle from/to addresses in multi-view

Summary

  • Depends on refactor: handle from/to addresses in multiview (mobile views) #924
  • useTransactionTableColumns hook has been refactored to support the hideSender prop. This will now hide or render the extra column for the sender.
  • This change will also update the name of the Value/Amount column.
  • TransactionTable component has been refactored to support the new recipient column when hideSender prop is false.

Screenshots

  • 1024px:
image
  • 1280px:
image
  • 1360px and higher:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jan 30, 2025 1:50pm

… into refactor/handle-from-to-addresses-in-multi-view-desktop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant