Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements on portfolio address management #929

Open
wants to merge 5 commits into
base: feat/evm
Choose a base branch
from

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jan 30, 2025

Summary

Closes https://app.clickup.com/t/86dvvmwv9
Closes https://app.clickup.com/t/86dvvbch0

  • Moves Dashboard vs Empty Dashboard rendering checks at the top level ( to a new Portfolio page), to avoid sub hooks & components having access to wallet, which makes them error prone if wallets are deleted (references to deleted objects/classes).

  • Fixes issue with race conditions between dashboard page and profile synchronizer that was altering the default address selection.

  • Adds logic to mark newly created or imported wallets as selected.

  • Persist selection on profile export & imports. If profile doesn't have pre-selected on import , all are marked as selected.

  • Better syncing of selected state between profile config & Address side panel's internal state.

  • Deleting the only selected wallet, should result into automatically selecting the next available.

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jan 30, 2025 4:08pm

…tHQ/arkvault into fix/address-selection-improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant