Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: total amount label styles in multi-address tx table #938

Conversation

patricio0312rev
Copy link
Contributor

[portfolio] adjust value labels in transactions table

Summary

image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Feb 4, 2025 11:16pm

@patricio0312rev patricio0312rev changed the base branch from develop to feat/evm February 3, 2025 15:03
@patricio0312rev patricio0312rev deleted the refactor/transaction-total-label-in-multiwallet-transactions-table branch February 3, 2025 15:09
@patricio0312rev patricio0312rev restored the refactor/transaction-total-label-in-multiwallet-transactions-table branch February 3, 2025 15:09
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to also drop the ARK text too next to the numeric value?. Not included in the designs.

Design
image

Imp
image

@samharperpittam samharperpittam marked this pull request as draft February 3, 2025 16:38
@patricio0312rev
Copy link
Contributor Author

@samharperpittam oki, I've updated that, but the logic to update the column name and the change you requested are in #940

This PR is just for the label styles 🌟

@patricio0312rev patricio0312rev marked this pull request as ready for review February 3, 2025 17:01
@samharperpittam
Copy link

@samharperpittam oki, I've updated that, but the logic to update the column name and the change you requested are in #940

This PR is just for the label styles 🌟

@patricio0312rev - sorry i think there's been some confusion with my latest comment.

The column header should retain the (ARK) text. However, the actual value in the table doesn't require the ARK text as it's stated in the header

image

@samharperpittam samharperpittam marked this pull request as draft February 4, 2025 16:04
@patricio0312rev
Copy link
Contributor Author

@samharperpittam should be fixed now 🌟

@patricio0312rev patricio0312rev marked this pull request as ready for review February 4, 2025 23:13
@ItsANameToo ItsANameToo changed the title refactor: total amount label styles in multiwallet transaction table refactor: total amount label styles in multi-address transaction table Feb 5, 2025
@ItsANameToo ItsANameToo changed the title refactor: total amount label styles in multi-address transaction table refactor: total amount label styles in multi-address tx table Feb 5, 2025
@ItsANameToo ItsANameToo merged commit 2f3c2bc into feat/evm Feb 5, 2025
17 checks passed
@ItsANameToo ItsANameToo deleted the refactor/transaction-total-label-in-multiwallet-transactions-table branch February 5, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants