Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_GPS Undulation is opposite common convention causing incorrect ellipsoid height #29199

Open
Ryanf55 opened this issue Jan 31, 2025 · 1 comment · May be fixed by #29200
Open

AP_GPS Undulation is opposite common convention causing incorrect ellipsoid height #29199

Ryanf55 opened this issue Jan 31, 2025 · 1 comment · May be fixed by #29200
Labels
BUG GPS Safety

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jan 31, 2025 •
edited
Loading

Bug report

Issue details

ArduPilot's idea of undulation is not following common convention. It's been this way since it was first implemented, and we have seen PR's come through to correct device drivers undulation, when in fact, ArduPilot was using the wrong definition.

See here for a report:

Ardupilot GPS Issue - PUBLIC3.pdf

If you use ellipsoid height for an algorithm, you may run into large offsets on some GPS's.

Version
Every version of ardupilot that publishes GPS_RAW_INT and dataflash logs to report UND, including master.

Platform
[x] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Airframe type
All

Hardware type
A few GPS's have been tested

Logs
N/A
@Ryanf55 Ryanf55 linked a pull request Jan 31, 2025 that will close this issue
Open
@tpwrules
Copy link
Contributor

After some experimentation and private discussion with Ryan it appears that (fortunately!) this issue does not affect the common use case of DroneCAN, UBX, or NMEA GPSes. When using these GPSes, whether through AP_Periph or a flight controller, the ellipsoid height is correct over MAVLink GPS_RAW_INT and/or DroneCAN's uavcan.equipment.gnss.Fix2 message. So the issue in these cases is only visible in dataflash GPA.Und.

This makes a fix a lot more palatable for me personally and I do think it is important for users of other GPSes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG GPS Safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AP_GPS: Fix undulation incorrect convention Ryanf55/ardupilot
2 participants
@tpwrules @Ryanf55