configuration of the minimum, maximum, tick amount of the y-axis #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwhhz This PR makes sense, could you please add the same option for: |
ArielMejiaDev
requested changes
Jan 24, 2024
| @@ -33,6 +33,18 @@ | |||
| xaxis: { | |||
| categories: {!! $chart->xAxis() !!} | |||
| }, | |||
| @if ($chart->yAxisMin() !== null && $chart->yAxisMax() !== null && $chart->yAxisTickAmount() !== null) | |||
There was a problem hiding this comment.
I would avoid too complex if statements, I would prefer to handle every property with it's own if statement or using a ternary operator
There was a problem hiding this comment.
after using Livewire 3 the if-statement doesnt work, so I removed it
marineusde
force-pushed
the
configuration-of-y-axis
branch
from
444deee to
cf2b21d
Compare
marineusde
force-pushed
the
configuration-of-y-axis
branch
from
cf2b21d to
0b33318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using: