Skip to content

Commit

Permalink
fix: missing slash in examples url printed after dataset upload (#6378)
Browse files Browse the repository at this point in the history
  • Loading branch information
RogerHYang authored Feb 13, 2025
1 parent c7f3e56 commit 67700f0
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/phoenix/session/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from io import BytesIO
from pathlib import Path
from typing import Any, BinaryIO, Literal, Optional, Union, cast
from urllib.parse import quote
from urllib.parse import quote, urljoin

import httpx
import pandas as pd
Expand Down Expand Up @@ -760,12 +760,14 @@ def _process_dataset_upload_response(self, response: Response) -> Dataset:
raise
data = response.json()["data"]
dataset_id = data["dataset_id"]
response = self._client.get(url=f"v1/datasets/{dataset_id}/examples")
path = f"v1/datasets/{dataset_id}/examples"
response = self._client.get(path)
response.raise_for_status()
data = response.json()["data"]
version_id = data["version_id"]
examples = data["examples"]
print(f"💾 Examples uploaded: {self.web_url}datasets/{dataset_id}/examples")
examples_url = urljoin(self.web_url, path)
print(f"💾 Examples uploaded: {examples_url}")
print(f"🗄️ Dataset version ID: {version_id}")

return Dataset(
Expand Down

0 comments on commit 67700f0

Please sign in to comment.