Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
RogerHYang committed Feb 6, 2025
1 parent ae8c048 commit ed3b1aa
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/phoenix/server/api/helpers/prompts/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,8 @@ class AnthropicToolDefinition(PromptModel):

def normalize_tools(
schemas: list[dict[str, Any]],
tool_choice: Optional[Union[str, Mapping[str, Any]]],
model_provider: str,
tool_choice: Optional[Union[str, Mapping[str, Any]]] = None,
) -> PromptToolsV1:
tools: list[PromptFunctionToolV1]
if model_provider.lower() == "openai":
Expand Down
12 changes: 10 additions & 2 deletions src/phoenix/server/api/mutations/prompt_mutations.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ async def create_chat_prompt(
)
try:
tools = (
normalize_tools(tool_definitions, tool_choice, input_prompt_version.model_provider)
normalize_tools(
tool_definitions,
input_prompt_version.model_provider,
tool_choice,
)
if tool_definitions
else None
)
Expand Down Expand Up @@ -160,7 +164,11 @@ async def create_chat_prompt_version(
)
try:
tools = (
normalize_tools(tool_definitions, tool_choice, input_prompt_version.model_provider)
normalize_tools(
tool_definitions,
input_prompt_version.model_provider,
tool_choice,
)
if tool_definitions
else None
)
Expand Down

0 comments on commit ed3b1aa

Please sign in to comment.