feat: Propagate prompt id to playground spans metadata #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| @@ -264,6 +267,10 @@ def input_value_and_mime_type( | |||
| yield INPUT_VALUE, safe_json_dumps(input_data) | |||
|
|
|||
|
|
|||
| def prompt_id_metadata(prompt_id: Optional[GlobalID]) -> Iterator[tuple[str, Any]]: | |||
| yield METADATA, {"phoenix-prompt-id": str(prompt_id)} | |||
There was a problem hiding this comment.
Do we always want to set this even when no prompt id is set?
| @@ -110,6 +110,7 @@ input ChatCompletionInput { | |||
| tools: [JSON!] | |||
| apiKey: String = null | |||
| template: TemplateOptions | |||
| promptId: GlobalID = null | |||
There was a problem hiding this comment.
Do we want to also add this to the nonStreaming mutation? That one does not carry over prompt id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6151
prompt_idcan now be optionally passed to playgroundChatCompletionInputandChatCompletionOverDatasetInputprompt_idwill be propagated to playground-generated spans