Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): support validators size change #286

Merged
merged 28 commits into from
Oct 31, 2023

Conversation

oXtxNt9U
Copy link
Contributor

@oXtxNt9U oXtxNt9U commented Oct 25, 2023

Summary

Support changing the validator count via milestones.

The main issue is that the consensus uses inconsistent milestones while it needs to use the milestones for the proposed height.

Milestone changes are now logged differently to make debugging easier:

Milestone change: {"height":"0 => 4","activeValidators":"3 => 7","reward":"0 => 200000000"}
Milestone change: {"height":"4 => 11","activeValidators":"7 => 4"}

Also adds TODOs in places that are potentially using the wrong milestones too, but are out of scope for this PR.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@oXtxNt9U oXtxNt9U marked this pull request as ready for review October 26, 2023 06:27
@sebastijankuzner sebastijankuzner merged commit 036b6cc into develop Oct 31, 2023
3 checks passed
@sebastijankuzner sebastijankuzner deleted the fix/dynamic-validators branch October 31, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants