feat(api-evm): implement eth_estimateGas
#836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oXtxNt9U
requested changes
Jan 27, 2025
There was a problem hiding this comment.
We need to check the account balance prior calling process else it's possible to panic:
thread 'tokio-runtime-worker' panicked at bindings/src/lib.rs:534:33:
not yet implemented: lack of funds (fee=105000000000000 balance=0)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Since we already call getAccountInfo to get the account, we should add a check for balance to cover fee+value.
oXtxNt9U
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist