feat(parser, tests): improving diagnostics for incomplete conditions …

…and loops

src/arkreactor/Compiler/AST/Parser.cpp

@@ -209,15 +209,15 @@ namespace Ark::internal
         if (auto condition = nodeOrValue(); condition.has_value())
             leaf->push_back(condition.value().attachNearestCommentBefore(comment));
         else
-            errorWithNextToken("If need a valid condition");
+            errorWithNextToken("`if' needs a valid condition");
 
         comment.clear();
         newlineOrComment(&comment);
 
         if (auto value_if_true = nodeOrValue(); value_if_true.has_value())
             leaf->push_back(value_if_true.value().attachNearestCommentBefore(comment));
         else
-            errorWithNextToken("Expected a value");
+            errorWithNextToken("Expected a node or value after condition");
 
         comment.clear();
         newlineOrComment(&comment);
@@ -252,15 +252,15 @@ namespace Ark::internal
         if (auto condition = nodeOrValue(); condition.has_value())
             leaf->push_back(condition.value().attachNearestCommentBefore(comment));
         else
-            errorWithNextToken("While need a valid condition");
+            errorWithNextToken("`while' needs a valid condition");
 
         comment.clear();
         newlineOrComment(&comment);
 
         if (auto body = nodeOrValue(); body.has_value())
             leaf->push_back(body.value().attachNearestCommentBefore(comment));
         else
-            errorWithNextToken("Expected a value");
+            errorWithNextToken("Expected a node or value after loop condition");
 
         setNodePosAndFilename(leaf->list().back());
         return leaf;

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_body_while.ark

@@ -0,0 +1 @@
+(while 1)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_body_while.expected

@@ -0,0 +1,5 @@
+At ) @ 1:9
+    1 | (while 1)
+      |         ^
+    2 |
+        Expected a node or value after loop condition

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_if.ark

@@ -0,0 +1 @@
+(if)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_if.expected

@@ -0,0 +1,5 @@
+At ) @ 1:4
+    1 | (if)
+      |    ^
+    2 |
+        `if' needs a valid condition

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_while.ark

@@ -0,0 +1 @@
+(while)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_cond_while.expected

@@ -0,0 +1,5 @@
+At ) @ 1:7
+    1 | (while)
+      |       ^
+    2 |
+        `while' needs a valid condition

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_then_if.ark

@@ -0,0 +1 @@
+(if 1)

tests/unittests/resources/DiagnosticsSuite/compileTime/missing_then_if.expected

@@ -0,0 +1,5 @@
+At ) @ 1:6
+    1 | (if 1)
+      |      ^
+    2 |
+        Expected a node or value after condition