feat(name resolution): prevent name collisions with builtins when res…

…olving namespaces

src/arkreactor/Compiler/NameResolution/NameResolutionPass.cpp

@@ -303,6 +303,17 @@ namespace Ark::internal
     {
         auto [allowed, fqn] = m_scope_resolver.canFullyQualifyName(symbol.string());
 
+        if (m_language_symbols.contains(fqn) && symbol.string() != fqn)
+        {
+            throw CodeError(
+                fmt::format(
+                    "Symbol `{}' was resolved to `{}', which is also a builtin name. Either the symbol or the package it's in needs to be renamed to avoid conflicting with the builtin.",
+                    symbol.string(), fqn),
+                symbol.filename(),
+                symbol.line(),
+                symbol.col(),
+                symbol.repr());
+        }
         if (!allowed)
         {
             std::string message;

tests/unittests/resources/DiagnosticsSuite/compileTime/name_collision_with_builtin.ark

@@ -0,0 +1,3 @@
+(import package.list :reverse)
+
+(print (reverse [1 2 3]))

tests/unittests/resources/DiagnosticsSuite/compileTime/name_collision_with_builtin.expected

@@ -0,0 +1,7 @@
+At reverse @ 3:9
+    1 | (import package.list :reverse)
+    2 |
+    3 | (print (reverse [1 2 3]))
+      |         ^~~~~~~
+    4 |
+        Symbol `reverse' was resolved to `list:reverse', which is also a builtin name. Either the symbol or the package it's in needs to be renamed to avoid conflicting with the builtin.

tests/unittests/resources/DiagnosticsSuite/compileTime/package/list.ark

@@ -0,0 +1 @@
+(let reverse (fun (l) l))