Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding pre-commit configuration #453

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat: adding pre-commit configuration #453

merged 2 commits into from
Apr 17, 2024

Conversation

SuperFola
Copy link
Member

@SuperFola SuperFola commented Apr 17, 2024

Description

Adding pre-commits hooks to:

  • check for and remove trailing whitespaces
  • ensure that a file is either empty, or ends with one newline
  • check yaml files for parseable syntax
  • prevent giant files from being committed
  • run clang-format on modified C++ code
  • run cppcheck on modified C++ code
  • check commit naming convention

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

Copy link

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN
./src/arkreactor/VM/VM.cpp 258:1153 Ark::VM::safeRun 2 644 165
./src/arkreactor/Compiler/BytecodeReader.cpp 70:438 Ark::BytecodeReader::display 4 327 131
./src/arkreactor/Compiler/Macros/Processor.cpp 219:463 Ark::internal::MacroProcessor::evaluate 2 206 72
./include/Ark/Compiler/AST/Parser.hpp 78:169 Ark::internal::ARK_APIParser::string 0 89 34
./src/arkscript/main.cpp 17:310 main 2 252 31
./src/arkreactor/Compiler/Compiler.cpp 530:635 Ark::Compiler::handleCalls 5 78 27
./src/arkreactor/Compiler/Compiler.cpp 261:352 Ark::Compiler::compileExpression 5 74 24
./src/arkreactor/Compiler/AST/Node.cpp 209:279 Ark::internal::operator < < 2 61 23
./src/arkscript/JsonCompiler.cpp 23:188 JsonCompiler::_compile 1 139 23
./src/arkreactor/VM/State.cpp 148:288 Ark::State::configure 0 116 22
./include/utf8.hpp 137:183 utf8::isValid 1 44 21
./src/arkreactor/Compiler/Macros/Processor.cpp 121:185 Ark::internal::MacroProcessor::processNode 2 48 20
./src/arkreactor/Compiler/AST/Parser.cpp 278:388 Ark::internal::Parser::import_ 0 89 19
./src/arkreactor/Compiler/Macros/Executors/Function.cpp 12:87 Ark::internal::FunctionExecutor::applyMacro 1 61 18
./src/arkreactor/Compiler/AST/Node.cpp 143:207 Ark::internal::Node::repr 0 56 17
./src/arkreactor/VM/Value.cpp 146:225 Ark::Value::toString 2 67 17
./include/Ark/Compiler/AST/Predicates.hpp 162:186 Ark::internal::IsSymbol::operator ( ) 1 24 16
./src/arkreactor/Compiler/Macros/Processor.cpp 53:101 Ark::internal::MacroProcessor::registerMacro 1 44 16
./src/arkscript/REPL/Repl.cpp 14:106 Ark::Repl::run 0 74 16
./src/arkreactor/TypeChecker.cpp 27:78 Ark::types::displayContract 2 45 15
./src/arkscript/Formatter.cpp 117:170 Formatter::format 3 51 15
./src/arkreactor/Exceptions.cpp 123:132 Ark::Diagnostics::helper 8 9 3
./include/Ark/Exceptions.hpp 109:118 Ark::CodeError::CodeError 6 10 1

CppCheck report


@SuperFola SuperFola merged commit ecb0547 into dev Apr 17, 2024
16 checks passed
@SuperFola SuperFola deleted the pre-commit branch April 17, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant