Skip to content

Commit

Permalink
Remove usage of "filters" in OWNERS
Browse files Browse the repository at this point in the history
The documentation states:
"WARNING: The approve plugin does not currently respect filters.
Until that is fixed, filters should only be used for the labels key (as shown in the above example)"

From now on we can only use OWNERS files per directory.

Signed-off-by: Luboslav Pivarc <[email protected]>
  • Loading branch information
xpivarc committed Aug 1, 2024
1 parent 2f4c074 commit 06963a1
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 68 deletions.
43 changes: 7 additions & 36 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,38 +1,9 @@
# See the OWNERS docs at https://go.k8s.io/owners

filters:
".*":
reviewers:
- code-reviewers
approvers:
- approvers
emeritus_approvers:
- emeritus_approvers

"cluster-up/.*|WORKSPACE|.bazel.*|.fossa.yml|cluster-up-sha.txt":
reviewers:
- sig-buildsystem-reviewers
approvers:
- sig-buildsystem-approvers
labels:
- sig/buildsystem
".*_test.go":
reviewers:
- sig-test-reviewers
approvers:
- sig-test-approvers
labels:
- sig/test
".golangci.yml":
approvers:
- sig-test-approvers
- sig-compute-approvers
- sig-network-approvers

"docs/metrics.md":
reviewers:
- sig-observability-reviewers
approvers:
- sig-observability-approvers
labels:
- sig/observability
reviewers:
- code-reviewers
approvers:
- approvers
emeritus_approvers:
- emeritus_approvers

7 changes: 7 additions & 0 deletions cluster-up/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
reviewers:
- sig-buildsystem-reviewers
approvers:
- sig-buildsystem-approvers
labels:
- sig/buildsystem

8 changes: 0 additions & 8 deletions cmd/OWNERS

This file was deleted.

23 changes: 6 additions & 17 deletions hack/OWNERS
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
filters:

".*":
reviewers:
- sig-buildsystem-reviewers
approvers:
- sig-buildsystem-approvers
labels:
- sig/buildsystem

".*perf.*":
reviewers:
- sig-scale-reviewers
approvers:
- sig-scale-approvers
labels:
- sig/scale
reviewers:
- sig-buildsystem-reviewers
approvers:
- sig-buildsystem-approvers
labels:
- sig/buildsystem
9 changes: 2 additions & 7 deletions staging/src/kubevirt.io/api/OWNERS
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
# See the OWNERS docs at https://go.k8s.io/owners

filters:
# examples:
# pkg/api/types.go
# pkg/api/*/register.go
"\\.go$":
labels:
- kind/api-change
labels:
- kind/api-change

0 comments on commit 06963a1

Please sign in to comment.