Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support AWS_MSK_IAM authentication #789

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

emef
Copy link
Contributor

@emef emef commented Nov 21, 2024

adds an AWS_MSK_IAM authentication type to the kafka config profile. submitting PR as a draft for early feedback while I do some testing on our deployment

proof that connection tester works (removed bootstrap servers from screenshot):
image

@emef emef marked this pull request as ready for review November 21, 2024 22:13
Copy link
Member

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks great! Just needs a clean cargo clippy run to merge. It looks like a test needs to be updated with the API changes.

Copy link
Member

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mwylde mwylde merged commit 4d57354 into ArroyoSystems:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants