Prevent division by zero #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great change, thank you! It would be awesome to see it merged on FSInteractiveMap. |
| @@ -45,6 +45,47 @@ - (void)setDefaultParameters | |||
|
|
|||
| #pragma mark - SVG map loading | |||
|
|
|||
| - (void)loadMap:(NSString*)mapName forSize:(CGSize)size withColors:(NSDictionary*)colorsDict { | |||
There was a problem hiding this comment.
There is a log of duplication in that method from - (void)loadMap:(NSString*)mapName withColors:(NSDictionary*)colorsDict. Can you try to factor it?
|
Hello, i need to show the name of the province on the map in China, what do i need to do? |
|
@ArthurGuibert can this PR being merged? Or at least have another PR with those lines? Happy to do it and help. Without this fix it crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a change to prevent a division by zero when there is only one value in the datas or one color.